Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): Add Date type to WhereValue #11612

Merged
merged 1 commit into from Oct 28, 2019
Merged

fix(typings): Add Date type to WhereValue #11612

merged 1 commit into from Oct 28, 2019

Conversation

ibarrae
Copy link
Contributor

@ibarrae ibarrae commented Oct 25, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Add Date type in WhereValue. Closes #11381

@codecov
Copy link

@codecov codecov bot commented Oct 25, 2019

Codecov Report

Merging #11612 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11612   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9190     9190           
=======================================
  Hits         8847     8847           
  Misses        343      343

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77c553...70f5be3. Read the comment docs.

@ibarrae ibarrae changed the title fix(typings): sequelize#11381 fix(typings): Add Date type to WhereValue Oct 25, 2019
papb
papb approved these changes Oct 27, 2019
Copy link
Member

@papb papb left a comment

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

LGTM

@papb papb added status: awaiting maintainer type: typescript labels Oct 27, 2019
@sushantdhiman sushantdhiman merged commit 3f8246f into sequelize:master Oct 28, 2019
4 checks passed
@sushantdhiman sushantdhiman removed the status: awaiting maintainer label Jan 29, 2020
@nabilzhafri
Copy link

@nabilzhafri nabilzhafri commented Mar 31, 2020

I'm using version 5.21.5, but apparently this fix seems to be missing. This hasnt been deployed yet?

@djejaquino
Copy link

@djejaquino djejaquino commented Nov 2, 2020

I'm using version 5.21.5, but apparently this fix seems to be missing. This hasnt been deployed yet?

Looks like so.

BTW @nabilzhafri, check if you have @types/sequelize on your package.json. That one is for 4.x, whereas sequelize@5.x has its own type definitions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants