Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): Add getDatabaseName type #11614

merged 1 commit into from Oct 28, 2019

fix(typings): Add getDatabaseName type #11614

merged 1 commit into from Oct 28, 2019


Copy link

@ibarrae ibarrae commented Oct 25, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Add getDatabaseName function type in Sequelize class type. Closes #11431

Copy link

@codecov codecov bot commented Oct 25, 2019

Codecov Report

Merging #11614 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11614   +/-   ##
  Coverage   96.26%   96.26%           
  Files          94       94           
  Lines        9190     9190           
  Hits         8847     8847           
  Misses        343      343

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77c553...3b76fe0. Read the comment docs.

* Returns the database name.

Copy link

@SimonSchick SimonSchick Oct 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rm the newline here pls?

Copy link

@papb papb commented Oct 27, 2019

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

@papb papb added status: awaiting response type: typescript labels Oct 27, 2019
@sushantdhiman sushantdhiman merged commit 1e1196d into sequelize:master Oct 28, 2019
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
status: awaiting response type: typescript
None yet

Successfully merging this pull request may close these issues.

4 participants