Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More precise beforeDestroy type #11618

Merged
merged 1 commit into from Oct 28, 2019
Merged

More precise beforeDestroy type #11618

merged 1 commit into from Oct 28, 2019

Conversation

thesame
Copy link
Contributor

@thesame thesame commented Oct 28, 2019

This is just an update to typescript model declaration that fixes "beforeDestroy" callback type.

@codecov
Copy link

@codecov codecov bot commented Oct 28, 2019

Codecov Report

Merging #11618 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11618   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9190     9190           
=======================================
  Hits         8847     8847           
  Misses        343      343

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77c553...371f4da. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 793ae53 into sequelize:master Oct 28, 2019
4 checks passed
@papb
Copy link
Member

@papb papb commented Oct 28, 2019

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants