Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add Includeable to IncludeOptions.include type #11622



Copy link

mrcrow85 commented Oct 29, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

This will update the field IncludeOptions.include type so that it now supports Includeable | Includeable[]. This change also affects other interfaces which were updated accordingly.

Closes #11376


This comment has been minimized.

Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #11622 into master will increase coverage by 2.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11622      +/-   ##
+ Coverage   94.18%   96.26%   +2.07%     
  Files          94       94              
  Lines        9190     9190              
+ Hits         8656     8847     +191     
+ Misses        534      343     -191
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.01% <0%> (+0.17%) ⬆️
lib/dialects/abstract/query.js 91.98% <0%> (+0.32%) ⬆️
lib/dialects/mysql/query-generator.js 97.83% <0%> (+3.03%) ⬆️
lib/sequelize.js 95.93% <0%> (+3.12%) ⬆️
lib/dialects/mysql/data-types.js 98.43% <0%> (+54.68%) ⬆️
lib/dialects/mysql/connection-manager.js 96.36% <0%> (+67.27%) ⬆️
lib/dialects/mysql/query.js 98.31% <0%> (+83.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757a986...43ce50c. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 43ba131 into sequelize:master Oct 30, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 757a986...43ce50c
codecov/project 96.26% (+2.07%) compared to 757a986
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

papb commented Oct 30, 2019


@mrcrow85 mrcrow85 deleted the stackbuilders:update-include-options-types branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.