Skip to content

Conversation

@mmena1
Copy link
Contributor

@mmena1 mmena1 commented Oct 29, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

This will update the field IncludeOptions.include type so that it now supports Includeable | Includeable[]. This change also affects other interfaces which were updated accordingly.

Closes #11376

@codecov
Copy link

codecov bot commented Oct 29, 2019

Codecov Report

Merging #11622 into master will increase coverage by 2.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11622      +/-   ##
==========================================
+ Coverage   94.18%   96.26%   +2.07%     
==========================================
  Files          94       94              
  Lines        9190     9190              
==========================================
+ Hits         8656     8847     +191     
+ Misses        534      343     -191
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.01% <0%> (+0.17%) ⬆️
lib/dialects/abstract/query.js 91.98% <0%> (+0.32%) ⬆️
lib/dialects/mysql/query-generator.js 97.83% <0%> (+3.03%) ⬆️
lib/sequelize.js 95.93% <0%> (+3.12%) ⬆️
lib/dialects/mysql/data-types.js 98.43% <0%> (+54.68%) ⬆️
lib/dialects/mysql/connection-manager.js 96.36% <0%> (+67.27%) ⬆️
lib/dialects/mysql/query.js 98.31% <0%> (+83.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757a986...43ce50c. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 43ba131 into sequelize:master Oct 30, 2019
@papb
Copy link
Member

papb commented Oct 30, 2019

Thanks!!

@papb papb added the typescript For issues and PRs. Things that involve typescript, such as typings and intellisense. label Oct 30, 2019
@mmena1 mmena1 deleted the update-include-options-types branch October 30, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typescript For issues and PRs. Things that involve typescript, such as typings and intellisense.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typings for IncludeOptions.include should accept Includeable | Includeable[]

3 participants