Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add isSoftDeleted to Model #11628

Merged
merged 2 commits into from Nov 22, 2019

Conversation

todd
Copy link
Contributor

@todd todd commented Oct 31, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

The TypeScript declarations currently lack a signature for isSoftDeleted on Model. This PR adds that signature.

@papb
Copy link
Member

@papb papb commented Nov 2, 2019

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

Please update your branch though, it is out-of-date with the master branch

papb
papb approved these changes Nov 2, 2019
@papb papb added status: awaiting response type: typescript labels Nov 2, 2019
@todd todd force-pushed the add_isSoftDeleted_types branch from 0c5d13c to 77f861e Compare Nov 4, 2019
@codecov
Copy link

@codecov codecov bot commented Nov 4, 2019

Codecov Report

Merging #11628 into master will decrease coverage by 6.38%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11628      +/-   ##
==========================================
- Coverage   96.26%   89.88%   -6.39%     
==========================================
  Files          94       92       -2     
  Lines        9190     9094      -96     
==========================================
- Hits         8847     8174     -673     
- Misses        343      920     +577
Impacted Files Coverage Δ
lib/dialects/mssql/query-generator.js 2.62% <0%> (-93.3%) ⬇️
lib/dialects/mssql/query-interface.js 8.69% <0%> (-91.31%) ⬇️
lib/dialects/mssql/query.js 5.58% <0%> (-89.95%) ⬇️
lib/dialects/mssql/resource-lock.js 22.22% <0%> (-77.78%) ⬇️
lib/dialects/mssql/data-types.js 30.12% <0%> (-69.88%) ⬇️
...dialects/abstract/query-generator/helpers/quote.js 93.33% <0%> (-6.67%) ⬇️
lib/dialects/abstract/query-generator.js 95.81% <0%> (-1.2%) ⬇️
lib/sequelize.js 95.31% <0%> (-0.63%) ⬇️
lib/query-interface.js 91.7% <0%> (-0.49%) ⬇️
lib/model.js 96.47% <0%> (-0.07%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb8cc3...ff239ac. Read the comment docs.

@papb papb added status: awaiting maintainer and removed status: awaiting response labels Nov 4, 2019
@sushantdhiman sushantdhiman merged commit beeff96 into sequelize:master Nov 22, 2019
1 of 2 checks passed
@sushantdhiman sushantdhiman removed the status: awaiting maintainer label Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants