Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add paranoid to UpdateOptions interface #11647

Merged
merged 1 commit into from Nov 9, 2019
Merged

fix(types): add paranoid to UpdateOptions interface #11647

merged 1 commit into from Nov 9, 2019

Conversation

mrcrow85
Copy link
Contributor

@mrcrow85 mrcrow85 commented Nov 5, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

This will add paranoid to the UpdateOptions interface. Closes #11200

@codecov
Copy link

@codecov codecov bot commented Nov 5, 2019

Codecov Report

Merging #11647 into master will increase coverage by 3.79%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11647      +/-   ##
==========================================
+ Coverage   92.47%   96.26%   +3.79%     
==========================================
  Files          91       94       +3     
  Lines        8903     9190     +287     
==========================================
+ Hits         8233     8847     +614     
+ Misses        670      343     -327
Impacted Files Coverage Δ
lib/dialects/sqlite/index.js 100% <0%> (ø)
lib/dialects/sqlite/query.js 98.65% <0%> (ø)
lib/dialects/sqlite/connection-manager.js 100% <0%> (ø)
lib/data-types.js 91.34% <0%> (+0.34%) ⬆️
lib/dialects/abstract/query-generator.js 97.01% <0%> (+0.51%) ⬆️
lib/dialects/abstract/query.js 91.98% <0%> (+0.96%) ⬆️
lib/sequelize.js 95.93% <0%> (+1.25%) ⬆️
lib/transaction.js 100% <0%> (+2.66%) ⬆️
lib/query-interface.js 92.19% <0%> (+3.41%) ⬆️
lib/errors/database/timeout-error.js 100% <0%> (+60%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbef15f...b476da7. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 21978eb into sequelize:master Nov 9, 2019
4 checks passed
@mrcrow85 mrcrow85 deleted the add-paranoid-to-UpdateOptions branch Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants