Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): generate ON CONFLICT ... DO UPDATE correctly #11666

Merged
merged 1 commit into from Nov 22, 2019

Conversation

@huned
Copy link
Contributor

huned commented Nov 11, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
    • npm run test-postgres fails... with 3 unrelated failures (details) that occur both before and after my commit to fix #11665
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • N/A [ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • N/A [ ] Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #11665

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #11666 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11666   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9190     9190           
=======================================
  Hits         8847     8847           
  Misses        343      343
Impacted Files Coverage Δ
lib/model.js 96.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3dd6a3...5f790d8. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 06a0d26 into sequelize:master Nov 22, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.26%)
Details
codecov/project 96.26% (+0%) compared to c3dd6a3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Restuta

This comment has been minimized.

Copy link

Restuta commented Dec 12, 2019

Do we know when this is going to be released? @sushantdhiman

@sushantdhiman

This comment has been minimized.

Copy link
Member

sushantdhiman commented Dec 12, 2019

Today @Restuta

@huned

This comment has been minimized.

Copy link
Contributor Author

huned commented Dec 12, 2019

👍 🎉

@huned huned deleted the huned:huned/bug-11665 branch Dec 12, 2019
@Restuta

This comment has been minimized.

Copy link

Restuta commented Dec 12, 2019

@sushantdhiman I see this one released https://github.com/sequelize/sequelize/releases/tag/v6.0.0-beta.4, any plans to release a patch for v5?

@sushantdhiman

This comment has been minimized.

Copy link
Member

sushantdhiman commented Dec 12, 2019

Someone will have to backport that fix to target v5 branch

Restuta added a commit to Restuta/sequelize that referenced this pull request Dec 12, 2019
Restuta added a commit to Restuta/sequelize that referenced this pull request Dec 12, 2019
@Restuta

This comment has been minimized.

Copy link

Restuta commented Dec 12, 2019

@sushantdhiman I hope I did it right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.