fix(model): generate ON CONFLICT ... DO UPDATE correctly#11666
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11666 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 94 94
Lines 9190 9190
=======================================
Hits 8847 8847
Misses 343 343
Continue to review full report at Codecov.
|
sushantdhiman
approved these changes
Nov 22, 2019
This was referenced Nov 22, 2019
|
Do we know when this is going to be released? @sushantdhiman |
Contributor
|
Today @Restuta |
Contributor
Author
|
👍 🎉 |
|
@sushantdhiman I see this one released https://github.com/sequelize/sequelize/releases/tag/v6.0.0-beta.4, any plans to release a patch for v5? |
Contributor
|
Someone will have to backport that fix to target v5 branch |
Restuta
added a commit
to Restuta/sequelize
that referenced
this pull request
Dec 12, 2019
6 tasks
Restuta
pushed a commit
to Restuta/sequelize
that referenced
this pull request
Dec 12, 2019
|
@sushantdhiman I hope I did it right :) |
sushantdhiman
pushed a commit
that referenced
this pull request
Dec 13, 2019
6 tasks
This was referenced Feb 3, 2020
This was referenced Mar 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?npm run test-postgresfails... with 3 unrelated failures (details) that occur both before and after my commit to fix bulkCreate generates incorrectON CONFLICT ... DO UPDATEclause when model has > 1 primary key field and column names differ from field names #11665[ ] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?[ ] Did you update the typescript typings accordingly (if applicable)?Description of change
Closes #11665