Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
docs(sequelize): typing of upsert interface to match code (#11673) #11674
@@ Coverage Diff @@ ## master #11674 +/- ## ======================================= Coverage 96.26% 96.26% ======================================= Files 94 94 Lines 9190 9190 ======================================= Hits 8847 8847 Misses 343 343
Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!
Please add at least one test to make sure your implementation works as intended and to prevent regressions in the future. Take a look into recent merged PRs to see how others created tests. If you have trouble, let me know.
Testing the TypeScript typings consists simply on checking if some code can be compiled. In other words, a typings test is just some TS code that should compile. What it does when executed is irrelevant, the test is simply to compile it without errors, as can be seen in our CI configuration (using
Let me know if you need further help!