Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): added 'fieldMaps' to QueryOptions typings #11702

merged 2 commits into from Dec 12, 2019


Copy link

techguysid commented Nov 22, 2019

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

This PR fixes the #11567 issue.

@techguysid techguysid force-pushed the techguysid:issue-11567 branch from 63514fd to bad33ba Nov 22, 2019

This comment has been minimized.

Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #11702 into master will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11702      +/-   ##
+ Coverage   95.83%   96.26%   +0.42%     
  Files          91       94       +3     
  Lines        8987     9190     +203     
+ Hits         8613     8847     +234     
+ Misses        374      343      -31
Impacted Files Coverage Δ
lib/dialects/mariadb/index.js 100% <0%> (ø)
lib/dialects/mariadb/connection-manager.js 100% <0%> (ø)
lib/dialects/mariadb/query.js 87.96% <0%> (ø)
lib/sequelize.js 95.93% <0%> (+0.62%) ⬆️
lib/dialects/postgres/connection-manager.js 95.77% <0%> (+1.4%) ⬆️
lib/query-interface.js 92.19% <0%> (+1.46%) ⬆️
lib/dialects/mariadb/data-types.js 100% <0%> (+49.01%) ⬆️
lib/dialects/mariadb/query-generator.js 100% <0%> (+85.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beeff96...d935920. Read the comment docs.


This comment has been minimized.

Copy link

zanctor commented Nov 25, 2019

@techguysid, seems like "fieldMap" property name should be singular, not plural.


This comment has been minimized.

Copy link
Contributor Author

techguysid commented Nov 25, 2019

@zanctor @papb - This is ok I mean all checks are passing, can you let me know if it looks good?


This comment has been minimized.

Copy link

zanctor commented Dec 6, 2019

@papb, will you have a chance to review and merge this pull request?

@sushantdhiman sushantdhiman merged commit 4dbabc0 into sequelize:master Dec 12, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing beeff96...d935920
codecov/project 96.26% (+0.42%) compared to beeff96
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

sushantdhiman commented Dec 12, 2019

No tests but not critical for typings. Thanks for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.