Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): injectDependentVirtualAttrs on included models #11713

Merged
merged 2 commits into from Dec 12, 2019

Conversation

@imathews
Copy link
Contributor

imathews commented Nov 27, 2019

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • n/a Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • n/a Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Properly injects dependent virtual attributes on included model. Closes #10930

Closes #10930
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #11713 into master will increase coverage by 0.42%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11713      +/-   ##
==========================================
+ Coverage   95.83%   96.26%   +0.42%     
==========================================
  Files          91       94       +3     
  Lines        8987     9191     +204     
==========================================
+ Hits         8613     8848     +235     
+ Misses        374      343      -31
Impacted Files Coverage Δ
lib/model.js 96.54% <100%> (ø) ⬆️
lib/dialects/mariadb/index.js 100% <0%> (ø)
lib/dialects/mariadb/connection-manager.js 100% <0%> (ø)
lib/dialects/mariadb/query.js 87.96% <0%> (ø)
lib/sequelize.js 95.93% <0%> (+0.62%) ⬆️
lib/dialects/postgres/connection-manager.js 95.77% <0%> (+1.4%) ⬆️
lib/query-interface.js 92.19% <0%> (+1.46%) ⬆️
lib/dialects/mariadb/data-types.js 100% <0%> (+49.01%) ⬆️
lib/dialects/mariadb/query-generator.js 100% <0%> (+85.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beeff96...40af450. Read the comment docs.

@sushantdhiman

This comment has been minimized.

Copy link
Member

sushantdhiman commented Dec 12, 2019

I have added a test for this case, if build is green we can merge it. Thanks for this contribution :)

@sushantdhiman sushantdhiman merged commit 6c1f15f into sequelize:master Dec 12, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 95.83%)
Details
codecov/project 96.26% (+0.42%) compared to beeff96
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.