Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #11726 - correct the overloaded method order #11727

Merged
merged 2 commits into from Jan 16, 2020

Conversation

@dancrumb
Copy link
Contributor

dancrumb commented Dec 3, 2019

No description provided.

When methods are overloaded, such that the different parameters are extensions of each other, the most specific signatures must come first.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #11727 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11727      +/-   ##
==========================================
+ Coverage   96.26%   96.26%   +<.01%     
==========================================
  Files          94       94              
  Lines        9190     9191       +1     
==========================================
+ Hits         8847     8848       +1     
  Misses        343      343
Impacted Files Coverage Δ
lib/query-interface.js 92.19% <ø> (ø) ⬆️
lib/sequelize.js 95.93% <ø> (ø) ⬆️
lib/model.js 96.54% <100%> (ø) ⬆️
lib/dialects/mssql/query.js 95.53% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e87cd...1973e5a. Read the comment docs.

@SimonSchick

This comment has been minimized.

Copy link
Member

SimonSchick commented Dec 12, 2019

I am not experiencing this issue at the moment, can you please provide a repro before we merge this?

@dancrumb

This comment has been minimized.

Copy link
Contributor Author

dancrumb commented Dec 12, 2019

Sure; there's one in the attached issue #11726

@dancrumb

This comment has been minimized.

Copy link
Contributor Author

dancrumb commented Dec 12, 2019

In addition, the discussion the led me to this conclusion is available in this issue: microsoft/TypeScript#35472

@papb

This comment has been minimized.

Copy link
Member

papb commented Jan 16, 2020

I'm convinced, I think this should be merged, even if this was just a refactor (which it is not), since I agree that more specific overloads should come first (even for readability only). And surely merging this can't be harmful, can it?

@SimonSchick can we merge this?

@papb
papb approved these changes Jan 16, 2020
@sushantdhiman sushantdhiman merged commit e1e82ed into sequelize:master Jan 16, 2020
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 96.26%)
Details
codecov/project 96.26% (+<.01%) compared to c1e87cd
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@papb papb mentioned this pull request Jan 16, 2020
2 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.