-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): adds 'hooks' to CreateOptions #11736
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11736 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 94 94
Lines 9203 9203
=======================================
Hits 8860 8860
Misses 343 343
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, just one request: please rename this HookOptions
interface you created to Hookable
, makes more sense to me and adheres to the style of other similar interfaces.
Dismissing this review since this request was already addressed
@eratio08 Thank you very much 😬 |
Pull Request check-list
Please make sure to review and check all of these items:
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description of change
Adds the missing
hooks
field to theCreateOptions
type mentioned here https://sequelize.org/v5/class/lib/model.js~Model.html#static-method-create