fix(types): adds 'hooks' to CreateOptions#11736
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11736 +/- ##
=======================================
Coverage 96.27% 96.27%
=======================================
Files 94 94
Lines 9203 9203
=======================================
Hits 8860 8860
Misses 343 343
Continue to review full report at Codecov.
|
SimonSchick
previously requested changes
Dec 12, 2019
papb
requested changes
Jan 16, 2020
papb
left a comment
Member
There was a problem hiding this comment.
Great work, just one request: please rename this HookOptions interface you created to Hookable, makes more sense to me and adheres to the style of other similar interfaces.
papb
dismissed
SimonSchick’s stale review
January 16, 2020 05:15
Dismissing this review since this request was already addressed
papb
approved these changes
Jan 21, 2020
Member
|
@eratio08 Thank you very much 😬 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Adds the missing
hooksfield to theCreateOptionstype mentioned here https://sequelize.org/v5/class/lib/model.js~Model.html#static-method-create