Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(*): corrects async/await example that uses transactions #11759

Merged
merged 2 commits into from Dec 23, 2019

Conversation

deezone
Copy link
Contributor

@deezone deezone commented Dec 18, 2019

Fixes #11758

Pull Request check-list

  • Documentation update

Description of change

This PR fixes a code example in the documentation under:

Advance Topics -> Migration Skeleton -> "The next is an example of a migration that has uses async/await where you create an unique index on a new column:"

image

https://sequelize.org/master/manual/migrations.html#migration-skeleton

@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #11759 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11759   +/-   ##
=======================================
  Coverage   96.26%   96.26%           
=======================================
  Files          94       94           
  Lines        9191     9191           
=======================================
  Hits         8848     8848           
  Misses        343      343

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3acc76d...4bda7e0. Read the comment docs.

@papb
Copy link
Member

papb commented Dec 23, 2019

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

papb
papb approved these changes Dec 23, 2019
@papb papb merged commit 712335b into sequelize:master Dec 23, 2019
@papb
Copy link
Member

papb commented Dec 23, 2019

Thanks 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid migration example using transactions
2 participants