docs(*): corrects async/await example that uses transactions - #11759
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11759 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 94 94
Lines 9191 9191
=======================================
Hits 8848 8848
Misses 343 343Continue to review full report at Codecov.
|
Member
|
Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future! |
papb
approved these changes
Dec 23, 2019
Member
|
Thanks 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11758
Pull Request check-list
Description of change
This PR fixes a code example in the documentation under:
Advance Topics -> Migration Skeleton -> "The next is an example of a migration that has uses async/await where you create an unique index on a new column:"
https://sequelize.org/master/manual/migrations.html#migration-skeleton