Added MSSQL domain auth example. - #11799
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11799 +/- ##
=======================================
Coverage 96.26% 96.26%
=======================================
Files 94 94
Lines 9191 9191
=======================================
Hits 8848 8848
Misses 343 343Continue to review full report at Codecov.
|
|
Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future! 😬 |
|
I have rebased your PR manually since my recently-merged PR #11825 caused a conflict here. |
|
Ah, no problem. There doesn't seem to be many people working with MSSQL, so it took me a while to figure out that the documentation wasn't exactly as clear as it could have been when it came to domain auth. The textual representation was a bid misleading in the docs. But, looks good! |
Creating this pull request to add an example to the MSSQL section for domain authentication. It took me a while to figure out how to do so in Sequelize when it was working in pure Tedious. The line in the docs, shown below, is what caused the confusion. Due to the statement, I had thought that all MSSQL specific configuration settings had to be in
optionsunderdialectOptions. Maybe the text can be changed, but I've added an example nonetheless.