docs(manuals): extensive rewrite#11825
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11825 +/- ##
==========================================
- Coverage 96.26% 94.18% -2.08%
==========================================
Files 94 94
Lines 9191 9191
==========================================
- Hits 8848 8657 -191
- Misses 343 534 +191
Continue to review full report at Codecov.
|
| include: [ | ||
| [ | ||
| // Note the wrapping parentheses in the call below! | ||
| sequelize.literal(`( |
There was a problem hiding this comment.
Hmm, include support this? Do we have any tests for this case?
There was a problem hiding this comment.
Good catch. We don't have any tests for this currently. However, it does work!! Should I just add one test for this? Or do you think this shouldn't be officially supported for some reason? I think it's great that it works :)
sushantdhiman
left a comment
There was a problem hiding this comment.
Looks really good. Left some comments, I'll run this locally in my evening time for final review.
@papb Thank you for doing this :D |
|
For those wondering, the docs website may take at most 48 hours to be updated. @sushantdhiman Can you manually trigger an update? |
|
This also closed #11365, I forgot to put it in the list! |
docs(manuals): extensive rewrite
Finally! This is the PR I have been working on for a few months.
I have basically rewritten the whole manuals. This will solve several issues at once.
Summary
The
docsfolder was reorganized;Almost every manual was rewritten;
Several new manuals were added;
A lot more examples were provided;
And I took care not to break any existing links!
Two of the manuals were renamed:
manual/dialects.htmlchanged tomanual/dialect-specific-things.html;manual/instances.htmlchanged tomanual/model-instances.html.To make sure the old links for these two still work, I have set up a permanent redirect for the old URLs to the new ones. See
docs/redirectsanddocs/redirects.json.The following five manuals were split into several pages, with a lot more details:
associations.md;data-types.md;models-definition.md;models-usage.md;querying.mdAgain, to make sure every link that is around the internet is still valid and useful, each of these pages became a mini-page linking for the new guides. See for example
docs/manual/moved/associations.md.Consequences
This PR will not only make me a lot more comfortable with the Sequelize guides in general, but will also close several issues!
uniquenot a validator? #2640