-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(typings): comparator arg of Sequelize.where
#11843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
comparator parameter a symbol is added as type
Codecov Report
@@ Coverage Diff @@
## master #11843 +/- ##
==========================================
+ Coverage 96.26% 96.27% +<.01%
==========================================
Files 94 94
Lines 9191 9203 +12
==========================================
+ Hits 8848 8860 +12
Misses 343 343
Continue to review full report at Codecov.
|
|
Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future! |
papb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add at least one test to make sure your implementation works as intended and to prevent regressions in the future.
Testing the TypeScript typings consists simply on checking if some code can be compiled. In other words, a typings test is just some TS code that should compile. What it does when executed is irrelevant, the test is simply to compile it without errors, as can be seen in our CI configuration (using npm run test-typings) here and here. Since it's just a compilation, getting no output from it means that it passed. Getting a compilation error is a failure. Note that if you directly throw an error from your typings test code, the test will still pass because throwing an error is something that compiles just fine.
For good examples on how to write typescript typings, check the following PRs: #11368 #11378 #11520
Let me know if you need further help!
comparator arg of Sequelize.where
a symbol and a null value are added
|
Good day Already perform the tipings test and everything is working correctly, also add other types to the |
|
Hello, you still haven't added a test. |
|
Hi Pedro, I already added some tests In the file |
|
@andres112013 Thank you very much! Before merging I would like to wait for a review by @SimonSchick as well |
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
In the types of the where function, in the comparator parameter a symbol is added as type, this solves problems when using the constant Op the function where
Example of the problem i had:
Closes #11241