Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): queryInterface.addIndex #11844

Merged
merged 3 commits into from Jan 19, 2020
Merged

fix(typings): queryInterface.addIndex #11844

merged 3 commits into from Jan 19, 2020

Conversation

papb
Copy link
Member

@papb papb commented Jan 18, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #11816

@papb papb changed the title [WIP] fix(typings): queryInterface.addIndex fix(typings): queryInterface.addIndex Jan 18, 2020
@papb papb added status: awaiting response type: typescript labels Jan 18, 2020
@codecov
Copy link

@codecov codecov bot commented Jan 18, 2020

Codecov Report

Merging #11844 into master will increase coverage by 21.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #11844       +/-   ##
===========================================
+ Coverage   74.61%   96.26%   +21.65%     
===========================================
  Files          85       94        +9     
  Lines        8358     9191      +833     
===========================================
+ Hits         6236     8848     +2612     
+ Misses       2122      343     -1779
Impacted Files Coverage Δ
lib/dialects/postgres/connection-manager.js 95.77% <ø> (ø)
lib/dialects/mariadb/connection-manager.js 100% <0%> (ø)
lib/dialects/mariadb/index.js 100% <0%> (ø)
lib/dialects/sqlite/index.js 100% <0%> (ø)
lib/dialects/mariadb/query.js 87.96% <0%> (ø)
lib/dialects/postgres/index.js 100% <0%> (ø)
lib/dialects/sqlite/query.js 98.65% <0%> (ø)
lib/dialects/sqlite/connection-manager.js 100% <0%> (ø)
lib/dialects/postgres/query.js 97.77% <0%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 449748a...37512e3. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 365d7c3 into master Jan 19, 2020
4 checks passed
@sushantdhiman sushantdhiman deleted the fix-11816 branch Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting response type: typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants