Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(increment): broken queries #11852

merged 7 commits into from
Jan 21, 2020

fix(increment): broken queries #11852

merged 7 commits into from
Jan 21, 2020


Copy link

@papb papb commented Jan 20, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Fixes #10719
Fixes #10411
Fixes #9572

Inspired by #11676, thanks @mhio and @ALiangLiang.

@papb papb changed the title [WIP] Fixing increment issues fix(increment): broken queries Jan 20, 2020
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #11852 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11852      +/-   ##
+ Coverage   96.26%   96.27%   +<.01%     
  Files          94       94              
  Lines        9191     9197       +6     
+ Hits         8848     8854       +6     
  Misses        343      343
Impacted Files Coverage Δ
lib/model.js 96.54% <100%> (ø) ⬆️
lib/query-interface.js 92.19% <100%> (ø) ⬆️
lib/dialects/abstract/query-generator.js 97.02% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 365d7c3...3eaf3c1. Read the comment docs.

@papb papb marked this pull request as ready for review January 21, 2020 01:17
* @param {Object} options
* @param {Object} attributes
* @private
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: here I am simply making explicit the fact that this method is private (since the whole namespace is already @private)

Copy link


@sushantdhiman sushantdhiman merged commit 51b0207 into master Jan 21, 2020
@sushantdhiman sushantdhiman deleted the fix-increment branch January 21, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants