other(find-all): throw on empty attributes #11867
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
papb added breaking change
For issues and PRs. Changes that break compatibility and require a major version increment.
status: awaiting maintainer
For PRs. Applied when the PR is ready for a maintainer to look.
For issues and PRs. Something that does not fit in any of the other "type:" labels.
Jan 23, 2020
@@ Coverage Diff @@ ## master #11867 +/- ## ========================================= - Coverage 96.27% 90.08% -6.2% ========================================= Files 94 93 -1 Lines 9217 9100 -117 ========================================= - Hits 8874 8198 -676 - Misses 343 902 +559
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.