Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo from Playes to Player #11869

Merged
merged 2 commits into from Jan 25, 2020
Merged

Fixed typo from Playes to Player #11869

merged 2 commits into from Jan 25, 2020

Conversation

@adkoge
Copy link
Contributor

adkoge commented Jan 24, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixed typo from Playes to Player

@papb
papb approved these changes Jan 24, 2020
Copy link
Member

papb left a comment

Thanks!

@papb papb self-assigned this Jan 24, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #11869 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11869   +/-   ##
=======================================
  Coverage   96.27%   96.27%           
=======================================
  Files          94       94           
  Lines        9209     9209           
=======================================
  Hits         8866     8866           
  Misses        343      343
Impacted Files Coverage Δ
lib/dialects/mysql/query.js 98.31% <0%> (ø) ⬆️
lib/dialects/mysql/connection-manager.js 96.36% <0%> (ø) ⬆️
lib/dialects/mysql/data-types.js 98.43% <0%> (ø) ⬆️
lib/sequelize.js 95.93% <0%> (ø) ⬆️
lib/dialects/mysql/query-generator.js 97.83% <0%> (ø) ⬆️
lib/dialects/postgres/connection-manager.js 95.77% <0%> (ø) ⬆️
lib/dialects/abstract/query.js 91.98% <0%> (ø) ⬆️
lib/dialects/abstract/query-generator.js 97.02% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d3be83...225352a. Read the comment docs.

@papb papb merged commit 22e6549 into sequelize:master Jan 25, 2020
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 9d3be83...225352a
Details
codecov/project 96.27% remains the same compared to 9d3be83
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.