Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tsd-test-setup): add & setup dtslint #11879

Merged
merged 5 commits into from Mar 16, 2020

Conversation

RobinBuschmann
Copy link
Member

@RobinBuschmann RobinBuschmann commented Jan 25, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

This PR adds and prepares dtslint in order to have better testing suite for testing typescript declarations. See #11829 for details.

solves #11829

@RobinBuschmann
Copy link
Member Author

RobinBuschmann commented Jan 25, 2020

@papb Here we go. dtslint allows us to write assertions for typescript declaration files like so:

// User.ts
class User extends Model {
  name!: string;
  age!: number;
}
// some-test.ts

// $ExpectType User
User.create({name: 'Marty'});

// $ExpectError
User.create({firstName: 'Marty'});

What do you think?

If we're fine with it we also should add some hints how to use it in CONTRIBUTING.md. Do we have any rules how to handle type script typings in the contribution guidelines? Couldn't find any.

@RobinBuschmann
Copy link
Member Author

RobinBuschmann commented Jan 25, 2020

Is there a way to see details for failed check continuous-integration/appveyor/pr?

@RobinBuschmann RobinBuschmann requested a review from papb Jan 30, 2020
@codecov
Copy link

codecov bot commented Feb 1, 2020

Codecov Report

Merging #11879 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11879   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          95       95           
  Lines        9215     9215           
=======================================
  Hits         8869     8869           
  Misses        346      346

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 761158c...030caca. Read the comment docs.

@RobinBuschmann RobinBuschmann marked this pull request as ready for review Feb 1, 2020
@RobinBuschmann RobinBuschmann mentioned this pull request Feb 6, 2020
6 tasks
@sushantdhiman
Copy link
Contributor

sushantdhiman commented Feb 20, 2020

/cc @papb / @SimonSchick

@sushantdhiman sushantdhiman added the status: awaiting maintainer For PRs. Applied when the PR is ready for a maintainer to look. label Feb 20, 2020
@RobinBuschmann
Copy link
Member Author

RobinBuschmann commented Feb 20, 2020

continuous-integration/appveyor/pr fails with:

bash : not found!
At line:4 char:3
+   bash codecov.sh -f "coverage\lcov.info"
+   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (not found!:String) [], RemoteException
    + FullyQualifiedErrorId : NativeCommandError

I think, there is nothing I can do to fix this?

@sushantdhiman sushantdhiman merged commit c845f0b into sequelize:master Mar 16, 2020
4 checks passed
@sushantdhiman sushantdhiman removed the status: awaiting maintainer For PRs. Applied when the PR is ready for a maintainer to look. label Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants