Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(manual): fix typos in assocs manual #11888

Merged
merged 2 commits into from
Feb 1, 2020

Conversation

gosuhiman
Copy link
Contributor

This PR contains simple fixes of typos in assocs manual - Foo and Bar was switched by mistake.

@gosuhiman gosuhiman requested a review from papb January 30, 2020 14:49
@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #11888 into master will decrease coverage by 3.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11888      +/-   ##
==========================================
- Coverage   96.27%   92.48%   -3.79%     
==========================================
  Files          94       91       -3     
  Lines        9209     8916     -293     
==========================================
- Hits         8866     8246     -620     
- Misses        343      670     +327
Impacted Files Coverage Δ
lib/dialects/sqlite/query-generator.js 2.91% <0%> (-93.69%) ⬇️
lib/dialects/sqlite/query-interface.js 15.62% <0%> (-84.38%) ⬇️
lib/dialects/sqlite/data-types.js 35.89% <0%> (-64.11%) ⬇️
lib/errors/database/timeout-error.js 40% <0%> (-60%) ⬇️
lib/query-interface.js 88.78% <0%> (-3.42%) ⬇️
lib/transaction.js 97.33% <0%> (-2.67%) ⬇️
lib/sequelize.js 94.68% <0%> (-1.25%) ⬇️
lib/dialects/abstract/query.js 91.02% <0%> (-0.97%) ⬇️
lib/dialects/abstract/query-generator.js 96.51% <0%> (-0.52%) ⬇️
lib/data-types.js 91% <0%> (-0.35%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344660e...e8877f0. Read the comment docs.

@papb
Copy link
Member

papb commented Feb 1, 2020

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

@papb papb added the type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. label Feb 1, 2020
@papb papb self-assigned this Feb 1, 2020
Copy link
Member

@papb papb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@papb papb merged commit 91416e3 into sequelize:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants