Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(index): improve to support multiple fields with operator #11934

Merged
merged 3 commits into from Feb 20, 2020

Conversation

@zbinlin
Copy link
Contributor

zbinlin commented Feb 18, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #7007

Also fixes #7007
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #11934 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11934   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files          95       95           
  Lines        9196     9200    +4     
=======================================
+ Hits         8850     8854    +4     
  Misses        346      346           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbf9139...13eeff7. Read the comment docs.

zbinlin added 2 commits Feb 18, 2020
@zbinlin zbinlin marked this pull request as ready for review Feb 19, 2020
@zbinlin zbinlin requested a review from SimonSchick Feb 19, 2020
@sushantdhiman

This comment has been minimized.

Copy link
Member

sushantdhiman commented Feb 20, 2020

LGTM, this should also fix #8553

Edit: It doesn't

@sushantdhiman sushantdhiman merged commit 5e85724 into sequelize:master Feb 20, 2020
4 checks passed
4 checks passed
codecov/patch 100.00% of diff hit (target 96.23%)
Details
codecov/project 96.23% (+0.00%) compared to bbf9139
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.