Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve query-interface removeIndex indexNameOrAttributes @param #11947

Merged

Conversation

dmshvetsov
Copy link
Contributor

@dmshvetsov dmshvetsov commented Feb 21, 2020

This change related exclusively to the documentation

@dmshvetsov dmshvetsov requested review from papb and sushantdhiman Feb 21, 2020
@papb
Copy link
Member

@papb papb commented Feb 21, 2020

Hello! I see you are a first-time contributor, thank you for taking the time to help Sequelize! I hope to see more PRs from you in the future!

lib/query-interface.js Outdated Show resolved Hide resolved
@papb papb added status: awaiting response type: docs labels Feb 21, 2020
@papb papb self-assigned this Feb 21, 2020
Co-Authored-By: Pedro Augusto de Paula Barbosa <papb1996@gmail.com>
@codecov
Copy link

@codecov codecov bot commented Feb 21, 2020

Codecov Report

Merging #11947 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11947   +/-   ##
=======================================
  Coverage   90.11%   90.11%           
=======================================
  Files          93       93           
  Lines        9104     9104           
=======================================
  Hits         8204     8204           
  Misses        900      900

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50da469...62b8453. Read the comment docs.

@dmshvetsov dmshvetsov requested a review from papb Feb 24, 2020
@sushantdhiman sushantdhiman merged commit b2a2134 into sequelize:master Feb 28, 2020
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting response type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants