fix(mssql): set correct scale for float#11962
Merged
sushantdhiman merged 2 commits intosequelize:masterfrom Mar 16, 2020
JohnOnLee:issue/11959
Merged
fix(mssql): set correct scale for float#11962sushantdhiman merged 2 commits intosequelize:masterfrom JohnOnLee:issue/11959
sushantdhiman merged 2 commits intosequelize:masterfrom
JohnOnLee:issue/11959
Conversation
pthongtaem
approved these changes
Mar 9, 2020
NatthawatS
approved these changes
Mar 11, 2020
Codecov Report
@@ Coverage Diff @@
## master #11962 +/- ##
==========================================
+ Coverage 96.23% 96.24% +<.01%
==========================================
Files 95 95
Lines 9202 9206 +4
==========================================
+ Hits 8856 8860 +4
Misses 346 346
Continue to review full report at Codecov.
|
7 tasks
7 tasks
firefueled
pushed a commit
to automindbr/sequelize
that referenced
this pull request
Apr 9, 2020
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
When we set type options of float for mssql, existing code blindly set it to precision 30, scale 15.
This could cause an issue with a large float value e.g. 43069.0122916667.
see issue tediousjs/tedious#1058
and #11959
to minimize the impact of the issue, we should at least set the scale correctly.