Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): fn is assigning to where #12040

Merged
merged 2 commits into from Mar 28, 2020
Merged

fix(typings): fn is assigning to where #12040

merged 2 commits into from Mar 28, 2020

Conversation

SimonSchick
Copy link
Contributor

@SimonSchick SimonSchick commented Mar 27, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Added Fn to the type union to allow performing model.findOne({ where: fn(...) }) which is currently supported by sequelize.

@SimonSchick SimonSchick requested a review from papb Mar 27, 2020
@codecov
Copy link

@codecov codecov bot commented Mar 27, 2020

Codecov Report

Merging #12040 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12040   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files          95       95           
  Lines        9215     9215           
=======================================
  Hits         8869     8869           
  Misses        346      346           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5822bc7...33f54e1. Read the comment docs.

papb
papb approved these changes Mar 27, 2020
@SimonSchick
Copy link
Contributor Author

@SimonSchick SimonSchick commented Mar 27, 2020

I think traves stumpled?

@papb papb merged commit c66663e into master Mar 28, 2020
4 checks passed
@SimonSchick SimonSchick deleted the fix/where-fn branch Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants