feat(sequelize): handle query string host value #12041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the query string `host` value to override the host value from the uri. The host query string is used to specify domain socket paths which cannot be specified in host part of a uri.
sushantdhiman
approved these changes
Apr 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description of change
Allow the query string
hostvalue to override the host value from theuri. The host query string is used to specify domain socket paths which
cannot be specified in host part of a uri.
I've found a few references online (including #695) which indicate that the
hostquery string value should work for domain sockets. However, upon review of the code and tests, this functionality may have been lost.Related: sequelize/cli#695
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?Did you update the typescript typings accordingly (if applicable)?