Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sequelize): handle query string host value #12041

Merged

Conversation

defunctzombie
Copy link
Contributor

@defunctzombie defunctzombie commented Mar 28, 2020

Description of change

Allow the query string host value to override the host value from the
uri. The host query string is used to specify domain socket paths which
cannot be specified in host part of a uri.

I've found a few references online (including #695) which indicate that the host query string value should work for domain sockets. However, upon review of the code and tests, this functionality may have been lost.

Related: sequelize/cli#695

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Allow the query string `host` value to override the host value from the
uri. The host query string is used to specify domain socket paths which
cannot be specified in host part of a uri.
@sushantdhiman sushantdhiman merged commit c071018 into sequelize:master Apr 4, 2020
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants