refactor(ci): improve database wait script#12132
Merged
sushantdhiman merged 1 commit intosequelize:masterfrom Apr 19, 2020
Merged
refactor(ci): improve database wait script#12132sushantdhiman merged 1 commit intosequelize:masterfrom
sushantdhiman merged 1 commit intosequelize:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12132 +/- ##
=======================================
Coverage 96.32% 96.32%
=======================================
Files 95 95
Lines 9226 9226
=======================================
Hits 8887 8887
Misses 339 339 Continue to review full report at Codecov.
|
sushantdhiman
approved these changes
Apr 19, 2020
Member
|
Fantastic!! Thank you very much @multum!! I stumbled into this in the past as well but ended up giving up... 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Replaced giorgos/takis with wilder/dockerize. Better interface and logs
resolves #12103