Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): improve database wait script #12132

Merged
merged 1 commit into from Apr 19, 2020
Merged

Conversation

multum
Copy link
Contributor

@multum multum commented Apr 19, 2020

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Replaced giorgos/takis with wilder/dockerize. Better interface and logs

resolves #12103

@codecov
Copy link

@codecov codecov bot commented Apr 19, 2020

Codecov Report

Merging #12132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12132   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          95       95           
  Lines        9226     9226           
=======================================
  Hits         8887     8887           
  Misses        339      339           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b671d2...090f996. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 1e6f9af into sequelize:master Apr 19, 2020
4 checks passed
@papb
Copy link
Member

@papb papb commented Apr 19, 2020

Fantastic!! Thank you very much @multum!! I stumbled into this in the past as well but ended up giving up... 😅

@papb papb added the type: other label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: other
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants