Skip to content

refactor(ci): improve database wait script#12132

Merged
sushantdhiman merged 1 commit intosequelize:masterfrom
multum:master
Apr 19, 2020
Merged

refactor(ci): improve database wait script#12132
sushantdhiman merged 1 commit intosequelize:masterfrom
multum:master

Conversation

@multum
Copy link
Contributor

@multum multum commented Apr 19, 2020

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Replaced giorgos/takis with wilder/dockerize. Better interface and logs

resolves #12103

@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #12132 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12132   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files          95       95           
  Lines        9226     9226           
=======================================
  Hits         8887     8887           
  Misses        339      339           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b671d2...090f996. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 1e6f9af into sequelize:master Apr 19, 2020
@papb
Copy link
Member

papb commented Apr 19, 2020

Fantastic!! Thank you very much @multum!! I stumbled into this in the past as well but ended up giving up... 😅

@papb papb added the type: other DEPRECATED: replace with the "meta" issue type label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: other DEPRECATED: replace with the "meta" issue type

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Waiting for database readiness after 'docker-compose up -d'

3 participants