Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use node native functions #12159

merged 2 commits into from Apr 24, 2020

refactor: use node native functions #12159

merged 2 commits into from Apr 24, 2020


Copy link

@SimonSchick SimonSchick commented Apr 23, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Some of the changes salvaged from my earlier dead branches.

  • Replaces _.values with the native variant Object.values function.
  • Removes a custom implementation of padding function with native (and removes some related dead code).
  • Removes manual stack capturing (no longer needed since node v8)

@SimonSchick SimonSchick requested review from sushantdhiman and papb Apr 23, 2020
@SimonSchick SimonSchick changed the title refactor: use native versions refactor: use node native functions Apr 23, 2020
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #12159 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12159   +/-   ##
  Coverage   96.34%   96.34%           
  Files          95       95           
  Lines        9229     9204   -25     
- Hits         8892     8868   -24     
+ Misses        337      336    -1     
Impacted Files Coverage Δ
lib/errors/association-error.js 100.00% <ø> (ø)
lib/errors/base-error.js 100.00% <ø> (ø)
lib/errors/bulk-record-error.js 100.00% <ø> (ø)
lib/errors/connection-error.js 100.00% <ø> (ø)
lib/errors/connection/access-denied-error.js 100.00% <ø> (ø)
...ors/connection/connection-acquire-timeout-error.js 100.00% <ø> (ø)
lib/errors/connection/connection-refused-error.js 100.00% <ø> (ø)
...ib/errors/connection/connection-timed-out-error.js 100.00% <ø> (ø)
lib/errors/connection/host-not-found-error.js 100.00% <ø> (ø)
lib/errors/connection/host-not-reachable-error.js 100.00% <ø> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c130d07...3687fc8. Read the comment docs.

@sushantdhiman sushantdhiman merged commit a0e244f into master Apr 24, 2020
4 checks passed
@sushantdhiman sushantdhiman deleted the chore/use-native branch Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants