Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): fix scope name on association scope #12204

Merged
merged 1 commit into from May 2, 2020
Merged

fix(docs): fix scope name on association scope #12204

merged 1 commit into from May 2, 2020

Conversation

JuarezLustosa
Copy link
Contributor

@JuarezLustosa JuarezLustosa commented May 1, 2020

Description of change

Simple documentation fix, wrong scope name.

Closes #12198

@codecov
Copy link

@codecov codecov bot commented May 1, 2020

Codecov Report

Merging #12204 into master will increase coverage by 2.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12204      +/-   ##
==========================================
+ Coverage   94.28%   96.34%   +2.05%     
==========================================
  Files          95       95              
  Lines        9181     9181              
==========================================
+ Hits         8656     8845     +189     
+ Misses        525      336     -189     
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.13% <0.00%> (+0.16%) ⬆️
lib/dialects/abstract/query.js 91.98% <0.00%> (+0.32%) ⬆️
lib/sequelize.js 95.87% <0.00%> (+3.17%) ⬆️
lib/dialects/mysql/query-generator.js 97.61% <0.00%> (+3.33%) ⬆️
lib/dialects/mysql/data-types.js 98.43% <0.00%> (+54.68%) ⬆️
lib/dialects/mysql/connection-manager.js 96.29% <0.00%> (+66.66%) ⬆️
lib/dialects/mysql/query.js 98.29% <0.00%> (+83.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5a60f9...e153652. Read the comment docs.

@sushantdhiman sushantdhiman merged commit e78da7f into sequelize:master May 2, 2020
4 checks passed
@JuarezLustosa JuarezLustosa deleted the fix/association_scopes_doc branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants