Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scope): don't modify original scope definition #12207

Merged
merged 1 commit into from May 2, 2020

Conversation

sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 2, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #12172

@codecov
Copy link

@codecov codecov bot commented May 2, 2020

Codecov Report

Merging #12207 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12207   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          95       95           
  Lines        9181     9181           
=======================================
  Hits         8845     8845           
  Misses        336      336           
Impacted Files Coverage Δ
lib/model.js 96.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e78da7f...92c2a15. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 4c674e2 into master May 2, 2020
4 checks passed
@sushantdhiman sushantdhiman deleted the clone-scope-on-scoping branch May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant