Skip to content

fix(sync): pass options to all query methods#12208

Merged
sushantdhiman merged 1 commit intomasterfrom
fix-sync-no-options-on-alter
May 2, 2020
Merged

fix(sync): pass options to all query methods#12208
sushantdhiman merged 1 commit intomasterfrom
fix-sync-no-options-on-alter

Conversation

@sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #12189

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #12208 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12208   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          95       95           
  Lines        9181     9182    +1     
=======================================
+ Hits         8845     8846    +1     
  Misses        336      336           
Impacted Files Coverage Δ
lib/model.js 96.60% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c674e2...66d30db. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 8d9e58b into master May 2, 2020
@sushantdhiman sushantdhiman deleted the fix-sync-no-options-on-alter branch May 2, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sync({ logging }) option not used for alter logs

1 participant