Skip to content

Handle literal substring starts ends with#12210

Merged
sushantdhiman merged 2 commits intomasterfrom
handle-literal-substring-starts-ends-with
May 2, 2020
Merged

Handle literal substring starts ends with#12210
sushantdhiman merged 2 commits intomasterfrom
handle-literal-substring-starts-ends-with

Conversation

@sushantdhiman
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #12073

@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #12210 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12210   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          95       95           
  Lines        9182     9183    +1     
=======================================
+ Hits         8846     8847    +1     
  Misses        336      336           
Impacted Files Coverage Δ
lib/dialects/abstract/query-generator.js 97.14% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9e58b...b5b225b. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 6fb74c8 into master May 2, 2020
@sushantdhiman sushantdhiman deleted the handle-literal-substring-starts-ends-with branch May 2, 2020 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Combination of [Op.substring] and sequelize.literal yields unexpected SQL query

1 participant