Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model.reload): ignore options.where and always use this.where() #12211

merged 1 commit into from May 2, 2020


Copy link

@sushantdhiman sushantdhiman commented May 2, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Fixes #12046

Now reload ignores options.where

Copy link

@codecov codecov bot commented May 2, 2020

Codecov Report

Merging #12211 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12211   +/-   ##
  Coverage   96.34%   96.34%           
  Files          95       95           
  Lines        9183     9183           
  Hits         8847     8847           
  Misses        336      336           
Impacted Files Coverage Δ
lib/model.js 96.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb74c8...5ca8608. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 5a4d260 into master May 2, 2020
4 checks passed
@sushantdhiman sushantdhiman deleted the reload-no-where branch May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

1 participant