Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): Change to uppercase on the described table #12212

Merged
merged 1 commit into from May 3, 2020
Merged

fix(mssql): Change to uppercase on the described table #12212

merged 1 commit into from May 3, 2020

Conversation

JuarezLustosa
Copy link
Contributor

@JuarezLustosa JuarezLustosa commented May 2, 2020

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fix an error on the described table.

Close #12193

@codecov
Copy link

@codecov codecov bot commented May 2, 2020

Codecov Report

Merging #12212 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12212   +/-   ##
=======================================
  Coverage   96.34%   96.34%           
=======================================
  Files          95       95           
  Lines        9183     9183           
=======================================
  Hits         8847     8847           
  Misses        336      336           
Impacted Files Coverage Δ
lib/dialects/mssql/query-generator.js 95.61% <ø> (ø)
lib/model.js 96.60% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fb74c8...cc82ef5. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 777ec09 into sequelize:master May 3, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants