Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pool): show deprecation when engine is not supported #12218

Merged
merged 4 commits into from May 4, 2020

Conversation

sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 3, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Update minimum database versions for #12186

@sushantdhiman sushantdhiman requested a review from May 3, 2020
@codecov
Copy link

@codecov codecov bot commented May 3, 2020

Codecov Report

Merging #12218 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12218   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          95       95           
  Lines        9112     9118    +6     
=======================================
+ Hits         8778     8784    +6     
  Misses        334      334           
Impacted Files Coverage Δ
lib/dialects/postgres/connection-manager.js 95.80% <ø> (ø)
lib/utils/class-to-invokable.js 100.00% <ø> (ø)
lib/data-types.js 91.37% <100.00%> (ø)
lib/dialects/abstract/connection-manager.js 91.80% <100.00%> (+0.27%) ⬆️
lib/dialects/mariadb/connection-manager.js 100.00% <100.00%> (ø)
lib/dialects/mariadb/index.js 100.00% <100.00%> (ø)
lib/dialects/mssql/index.js 100.00% <100.00%> (ø)
lib/dialects/mysql/index.js 100.00% <100.00%> (ø)
lib/dialects/postgres/index.js 100.00% <100.00%> (ø)
lib/dialects/sqlite/index.js 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c624c0e...b95e0df. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 6d116f8 into master May 4, 2020
4 checks passed
@sushantdhiman sushantdhiman deleted the database-engine-version-validity branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant