Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query-interface): allow sequelize.fn and sequelize.literal in fields of IndexesOptions #12224

Merged
merged 3 commits into from May 8, 2020

Conversation

ssut
Copy link
Contributor

@ssut ssut commented May 4, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

As far as I know, sequelize allows sequelize.fn and sequelize.literal to be used for indexes.fields when defining models, because I have seen that the current sequelize types seem it does not allow to do so, this pull request solves the problem.

(Documented on https://sequelize.org/master/class/lib/model.js~Model.html)

Screen Shot 2020-05-05 at 23 23 25

@codecov
Copy link

@codecov codecov bot commented May 4, 2020

Codecov Report

Merging #12224 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12224   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          95       95           
  Lines        9118     9118           
=======================================
  Hits         8784     8784           
  Misses        334      334           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c013246...74f5e39. Read the comment docs.

Copy link
Contributor

@SimonSchick SimonSchick left a comment

Missing test, you also did not fill out the PR template correctly.

@ssut ssut requested a review from SimonSchick May 5, 2020
@ssut
Copy link
Contributor Author

@ssut ssut commented May 7, 2020

Missing test, you also did not fill out the PR template correctly.

I added a test for this pull request. Please check it.

@sushantdhiman sushantdhiman merged commit 839f1a9 into sequelize:master May 8, 2020
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants