Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: remove unnecessary comment on typescript #12226

Merged
merged 3 commits into from May 8, 2020
Merged

Doc: remove unnecessary comment on typescript #12226

merged 3 commits into from May 8, 2020

Conversation

JuarezLustosa
Copy link
Contributor

@JuarezLustosa JuarezLustosa commented May 4, 2020

Description of change

Simple documentation fix.

Closes #12081

@codecov
Copy link

@codecov codecov bot commented May 4, 2020

Codecov Report

Merging #12226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12226   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          95       95           
  Lines        9118     9118           
=======================================
  Hits         8784     8784           
  Misses        334      334           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839f1a9...8709685. Read the comment docs.

Copy link
Member

@papb papb left a comment

Hello, thanks for the PR! However, as it stands it does not really close #12081 since it addresses only the first half of it.

Please update your PR applying my suggestion and it will be ready!

@papb papb added status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference. labels May 5, 2020
@papb papb self-assigned this May 5, 2020
papb
papb approved these changes May 8, 2020
@papb papb merged commit 4c1ce2b into sequelize:master May 8, 2020
2 checks passed
@papb papb removed the status: awaiting response For issues and PRs. OP must respond (or change something, if it is a PR). Maintainers have no action label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs For issues and PRs. Things related to documentation, such as changes in the manuals / API reference.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants