Doc: remove unnecessary comment on typescript#12226
Merged
papb merged 3 commits intoMay 8, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12226 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 95 95
Lines 9118 9118
=======================================
Hits 8784 8784
Misses 334 334 Continue to review full report at Codecov.
|
papb
requested changes
May 5, 2020
papb
left a comment
papb
left a comment
Member
There was a problem hiding this comment.
Hello, thanks for the PR! However, as it stands it does not really close #12081 since it addresses only the first half of it.
Please update your PR applying my suggestion and it will be ready!
papb
added
status: awaiting response
papb
approved these changes
May 8, 2020
papb
removed
the
status: awaiting response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
Simple documentation fix.
Closes #12081