Skip to content

Conversation

@JuarezLustosa
Copy link
Contributor

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Close this issue #12203

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #12250 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12250   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          95       95           
  Lines        9118     9120    +2     
=======================================
+ Hits         8784     8786    +2     
  Misses        334      334           
Impacted Files Coverage Δ
lib/dialects/abstract/query.js 91.98% <100.00%> (ø)
lib/dialects/sqlite/query-generator.js 96.63% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14972b...8c9d480. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 4dbfb5d into sequelize:master May 14, 2020
@sushantdhiman
Copy link
Contributor

Thanks for this concise fix @JuarezLustosa 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants