Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query) Do not bind character with $ on the middle #12250

Merged
merged 1 commit into from May 14, 2020
Merged

fix(query) Do not bind character with $ on the middle #12250

merged 1 commit into from May 14, 2020

Conversation

JuarezLustosa
Copy link
Contributor

@JuarezLustosa JuarezLustosa commented May 13, 2020

Pull Request check-list

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Close this issue #12203

@codecov
Copy link

@codecov codecov bot commented May 13, 2020

Codecov Report

Merging #12250 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12250   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          95       95           
  Lines        9118     9120    +2     
=======================================
+ Hits         8784     8786    +2     
  Misses        334      334           
Impacted Files Coverage Δ
lib/dialects/abstract/query.js 91.98% <100.00%> (ø)
lib/dialects/sqlite/query-generator.js 96.63% <0.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c14972b...8c9d480. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 4dbfb5d into sequelize:master May 14, 2020
4 checks passed
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 14, 2020

Thanks for this concise fix @JuarezLustosa 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants