Skip to content

feat(belongs-to-many): get/has/count for paranoid join table#12256

Merged
sushantdhiman merged 1 commit into
masterfrom
paranoid-has-get-count-belongs-to-many
May 16, 2020
Merged

feat(belongs-to-many): get/has/count for paranoid join table#12256
sushantdhiman merged 1 commit into
masterfrom
paranoid-has-get-count-belongs-to-many

Conversation

@sushantdhiman

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Fixes #6790

@codecov

codecov Bot commented May 16, 2020

Copy link
Copy Markdown

Codecov Report

Merging #12256 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12256   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          95       95           
  Lines        9120     9120           
=======================================
  Hits         8786     8786           
  Misses        334      334           
Impacted Files Coverage Δ
lib/associations/belongs-to-many.js 98.02% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b49a24d...40fe3b9. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 9a95e72 into master May 16, 2020
@sushantdhiman sushantdhiman deleted the paranoid-has-get-count-belongs-to-many branch May 16, 2020 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Paranoid flag doesn't work with hasAssociation

1 participant