Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mssql): order with include generates duplicate order #12257

Merged
merged 5 commits into from May 16, 2020

Conversation

sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 16, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Continuing #8070 with tests

Fixes #7851
Fixes #11636
Fixes #9448
Fixes #11258
Closes #8070

@codecov
Copy link

@codecov codecov bot commented May 16, 2020

Codecov Report

Merging #12257 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12257   +/-   ##
=======================================
  Coverage   96.33%   96.34%           
=======================================
  Files          95       95           
  Lines        9120     9126    +6     
=======================================
+ Hits         8786     8792    +6     
  Misses        334      334           
Impacted Files Coverage Δ
lib/dialects/mssql/query-generator.js 95.69% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a95e72...6a92043. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 4d75caf into master May 16, 2020
4 checks passed
@sushantdhiman sushantdhiman deleted the fix-mssql-primary-key-order branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant