Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(associations): ensure correct schema on all generated attributes #12258

merged 2 commits into from May 16, 2020


Copy link

@sushantdhiman sushantdhiman commented May 16, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Fixes an general issue with association, improper merging of newly generated attributes was overriding schema based toString fn with Object.isString

Closes #10125

Copy link

@codecov codecov bot commented May 16, 2020

Codecov Report

Merging #12258 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12258      +/-   ##
- Coverage   96.34%   96.33%   -0.01%     
  Files          95       95              
  Lines        9126     9125       -1     
- Hits         8792     8791       -1     
  Misses        334      334              
Impacted Files Coverage Δ
lib/dialects/mssql/query-generator.js 95.69% <ø> (ø)
lib/dialects/mysql/query-generator.js 97.61% <ø> (ø)
lib/associations/helpers.js 100.00% <100.00%> (ø)
lib/utils.js 98.31% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d75caf...ecfd593. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 461c924 into master May 16, 2020
3 of 4 checks passed
@sushantdhiman sushantdhiman deleted the references-model-fix branch May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant