fix(postgres): addColumn support ARRAY(ENUM)#12259
Conversation
| }); | ||
| }); | ||
|
|
||
| if (dialect === 'postgres') { |
There was a problem hiding this comment.
For some reason I was convinced that test have to cover all dialects.
Unfortunately my pr without answer (#10561 (comment)) was hanging for a year, I could have done that if myself if someone had replied to me in the thread that I can test for just one dialect.
On one side I am happy we merged my fix, on the other I am sad I won't show as the contributor for it although this is a clear c/p of my pr.
There was a problem hiding this comment.
Hey @mieszko4, ARRAY(ENUM) is postgres only feature, so we only need to cover postgres. Sorry that original PR was left in limbo. I could have commented there but
- I wasn't sure if author will still respond after a year
- Main code and test needed some improvement, which would have taken some extra time.
So I improved code and merged it. Thanks for you initial work
There was a problem hiding this comment.
Hey @sushantdhiman, sure, no problem, I understand. thnx for the explanation and your contribution overall!
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
Closes #10561