Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postgres): addColumn support ARRAY(ENUM) #12259

Merged
merged 1 commit into from May 16, 2020
Merged

Conversation

sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 16, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #10561

@sushantdhiman sushantdhiman merged commit 18dcc7e into master May 16, 2020
1 of 2 checks passed
@sushantdhiman sushantdhiman deleted the pg-add-column-array-enum branch May 16, 2020
@@ -380,6 +380,23 @@ describe(Support.getTestDialectTeaser('QueryInterface'), () => {
values: ['value1', 'value2', 'value3']
});
});

if (dialect === 'postgres') {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I was convinced that test have to cover all dialects.
Unfortunately my pr without answer (#10561 (comment)) was hanging for a year, I could have done that if myself if someone had replied to me in the thread that I can test for just one dialect.

On one side I am happy we merged my fix, on the other I am sad I won't show as the contributor for it although this is a clear c/p of my pr.

Copy link
Contributor Author

@sushantdhiman sushantdhiman May 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mieszko4, ARRAY(ENUM) is postgres only feature, so we only need to cover postgres. Sorry that original PR was left in limbo. I could have commented there but

  1. I wasn't sure if author will still respond after a year
  2. Main code and test needed some improvement, which would have taken some extra time.

So I improved code and merged it. Thanks for you initial work

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sushantdhiman, sure, no problem, I understand. thnx for the explanation and your contribution overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants