Skip to content

fix(postgres): addColumn support ARRAY(ENUM)#12259

Merged
sushantdhiman merged 1 commit intomasterfrom
pg-add-column-array-enum
May 16, 2020
Merged

fix(postgres): addColumn support ARRAY(ENUM)#12259
sushantdhiman merged 1 commit intomasterfrom
pg-add-column-array-enum

Conversation

@sushantdhiman
Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #10561

@sushantdhiman sushantdhiman merged commit 18dcc7e into master May 16, 2020
@sushantdhiman sushantdhiman deleted the pg-add-column-array-enum branch May 16, 2020 13:10
});
});

if (dialect === 'postgres') {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason I was convinced that test have to cover all dialects.
Unfortunately my pr without answer (#10561 (comment)) was hanging for a year, I could have done that if myself if someone had replied to me in the thread that I can test for just one dialect.

On one side I am happy we merged my fix, on the other I am sad I won't show as the contributor for it although this is a clear c/p of my pr.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mieszko4, ARRAY(ENUM) is postgres only feature, so we only need to cover postgres. Sorry that original PR was left in limbo. I could have commented there but

  1. I wasn't sure if author will still respond after a year
  2. Main code and test needed some improvement, which would have taken some extra time.

So I improved code and merged it. Thanks for you initial work

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sushantdhiman, sure, no problem, I understand. thnx for the explanation and your contribution overall!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants