fix(mssql): no default returning in update#12260
Merged
Merged
Conversation
faf4f9b to
aa1ecca
Compare
Codecov Report
@@ Coverage Diff @@
## master #12260 +/- ##
==========================================
- Coverage 96.34% 96.34% -0.01%
==========================================
Files 95 95
Lines 9128 9127 -1
==========================================
- Hits 8794 8793 -1
Misses 334 334
Continue to review full report at Codecov.
|
ShaharHD
added a commit
to ShaharHD/sequelize
that referenced
this pull request
Jun 23, 2020
Reference for change is based on sequelize#12260 - use rowCount intead of data.length when not returning data
ShaharHD
added a commit
to ShaharHD/sequelize
that referenced
this pull request
Jun 25, 2020
Reference for change is based on sequelize#12260 - use rowCount intead of data.length when not returning data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
This is a breaking change for MSSQL. MSSQL lacks ability to returnaffectedRowsfor update operation withoutOUTPUT INSERTED.*statement. As this PR fixes that behavior, we are not automatically injecting that statement.So MSSQL users if needaffectedRowscount fromupdate, will need to call it withreturning: trueSupports disabling
OUTPUT INSERTED.*withreturning: falseCloses #11203
Fixes #11304
Fixes #11201