Skip to content

fix: remove custom inspect#12262

Merged
sushantdhiman merged 1 commit into
masterfrom
remove-custom-inspect
May 17, 2020
Merged

fix: remove custom inspect#12262
sushantdhiman merged 1 commit into
masterfrom
remove-custom-inspect

Conversation

@sushantdhiman

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in CONTRIBUTING.md?

Description of change

Closes #10104

@codecov

codecov Bot commented May 17, 2020

Copy link
Copy Markdown

Codecov Report

Merging #12262 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12262      +/-   ##
==========================================
+ Coverage   96.34%   96.36%   +0.02%     
==========================================
  Files          95       95              
  Lines        9127     9125       -2     
==========================================
  Hits         8793     8793              
+ Misses        334      332       -2     
Impacted Files Coverage Δ
lib/associations/base.js 100.00% <ø> (+5.00%) ⬆️
lib/model.js 96.63% <ø> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e51d2a...071da71. Read the comment docs.

@sushantdhiman
sushantdhiman merged commit 8a1429d into master May 17, 2020
@sushantdhiman
sushantdhiman deleted the remove-custom-inspect branch May 17, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated use of custom inspect function DEP0079

1 participant