Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(query-interface): fix broken links #12272

Merged
merged 1 commit into from May 19, 2020
Merged

Conversation

papb
Copy link
Member

@papb papb commented May 18, 2020

Links to queryInterface API reference are broken in docs since #12217

Closes #12270

@papb papb added status: awaiting maintainer type: docs labels May 18, 2020
@codecov
Copy link

@codecov codecov bot commented May 18, 2020

Codecov Report

Merging #12272 into master will decrease coverage by 2.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12272      +/-   ##
==========================================
- Coverage   96.36%   94.26%   -2.10%     
==========================================
  Files          95       95              
  Lines        9125     9125              
==========================================
- Hits         8793     8602     -191     
- Misses        332      523     +191     
Impacted Files Coverage Δ
lib/dialects/mysql/query.js 14.52% <0.00%> (-83.77%) ⬇️
lib/dialects/mysql/connection-manager.js 29.62% <0.00%> (-66.67%) ⬇️
lib/dialects/mysql/data-types.js 43.75% <0.00%> (-54.69%) ⬇️
lib/dialects/mysql/query-generator.js 94.28% <0.00%> (-3.34%) ⬇️
lib/sequelize.js 92.60% <0.00%> (-3.22%) ⬇️
lib/dialects/postgres/connection-manager.js 94.40% <0.00%> (-1.40%) ⬇️
lib/dialects/abstract/query.js 91.66% <0.00%> (-0.33%) ⬇️
lib/dialects/abstract/query-generator.js 96.97% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1429d...7a3a4d5. Read the comment docs.

@papb
Copy link
Member Author

@papb papb commented May 18, 2020

Codecov has to be fixed at some point 😅

Copy link
Contributor

@sushantdhiman sushantdhiman left a comment

👍

@sushantdhiman sushantdhiman merged commit 3e4b5ed into master May 19, 2020
3 of 4 checks passed
@sushantdhiman sushantdhiman deleted the docs-broken-qi-link branch May 19, 2020
@papb papb removed the status: awaiting maintainer label May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants