fix(model destroy): Return 0 when options is truncate. #12281
Merged
sushantdhiman merged 5 commits intosequelize:masterfrom Jun 8, 2020
JuarezLustosa:feature/add_more_info_on_destroy_truncate
Merged
fix(model destroy): Return 0 when options is truncate. #12281sushantdhiman merged 5 commits intosequelize:masterfrom JuarezLustosa:feature/add_more_info_on_destroy_truncate
sushantdhiman merged 5 commits intosequelize:masterfrom
JuarezLustosa:feature/add_more_info_on_destroy_truncate
Conversation
sobrinho
approved these changes
May 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #12281 +/- ##
==========================================
+ Coverage 96.33% 96.40% +0.06%
==========================================
Files 95 95
Lines 9118 9116 -2
==========================================
+ Hits 8784 8788 +4
+ Misses 334 328 -6
Continue to review full report at Codecov.
|
sobrinho
reviewed
May 20, 2020
Co-authored-by: Gabriel Sobrinho <gabriel.sobrinho@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
npm run testornpm run test-DIALECTpass with this change (including linting)?Description of change
This close #12164.
I was debugging and realize, the SSCE examples is passing truncate as an option. Therefore truncate on the database does not show affected rows so we can't return the value, thus I found the Postgres NaN in these cases.