Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing sql and parameters properties to some query errors #12299

merged 1 commit into from May 23, 2020


Copy link

@jedwards1211 jedwards1211 commented May 23, 2020

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Copy link

@codecov codecov bot commented May 23, 2020

Codecov Report

Merging #12299 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12299      +/-   ##
- Coverage   96.36%   96.34%   -0.03%     
  Files          95       95              
  Lines        9125     9127       +2     
  Hits         8793     8793              
- Misses        332      334       +2     
Impacted Files Coverage Δ
lib/dialects/mssql/query.js 94.62% <0.00%> (-1.03%) ⬇️
lib/dialects/postgres/query.js 97.83% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31d68d...f432638. Read the comment docs.

@sushantdhiman sushantdhiman merged commit d7fcf21 into sequelize:master May 23, 2020
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants