Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup query generators #12304

merged 1 commit into from May 24, 2020

refactor: cleanup query generators #12304

merged 1 commit into from May 24, 2020


Copy link

@sushantdhiman sushantdhiman commented May 24, 2020

Pull Request check-list

Please make sure to review and check all of these items:

  • Does npm run test or npm run test-DIALECT pass with this change (including linting)?
  • Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • Have you added new tests to prevent regressions?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Did you update the typescript typings accordingly (if applicable)?
  • Did you follow the commit message conventions explained in

Description of change

Rename / remove some internal methods

Copy link

@codecov codecov bot commented May 24, 2020

Codecov Report

Merging #12304 into master will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12304      +/-   ##
+ Coverage   96.29%   96.40%   +0.10%     
  Files          95       95              
  Lines        9127     9117      -10     
  Hits         8789     8789              
+ Misses        338      328      -10     
Impacted Files Coverage Δ
lib/dialects/mssql/query-generator.js 95.69% <ø> (ø)
lib/dialects/mysql/query-generator.js 97.56% <ø> (ø)
lib/dialects/postgres/query-generator.js 94.93% <100.00%> (+2.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d9165b...d848891. Read the comment docs.

@sushantdhiman sushantdhiman merged commit 0769aea into master May 24, 2020
4 checks passed
@sushantdhiman sushantdhiman deleted the cleanup-pg-qg branch May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant