Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make documentation responsive #12308

Merged
merged 5 commits into from Jun 1, 2020
Merged

Make documentation responsive #12308

merged 5 commits into from Jun 1, 2020

Conversation

soryy708
Copy link
Contributor

@soryy708 soryy708 commented May 24, 2020

Description of change

closes #11453

@codecov
Copy link

@codecov codecov bot commented May 24, 2020

Codecov Report

Merging #12308 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #12308   +/-   ##
=======================================
  Coverage   96.40%   96.40%           
=======================================
  Files          95       95           
  Lines        9115     9115           
=======================================
  Hits         8787     8787           
  Misses        328      328           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b8a7b...d876ac1. Read the comment docs.

@sushantdhiman sushantdhiman requested a review from papb May 25, 2020
@papb
Copy link
Member

@papb papb commented May 25, 2020

Hello, thanks for the PR, I will try to take a look later today

@soryy708
Copy link
Contributor Author

@soryy708 soryy708 commented May 27, 2020

@papb sup?

@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented May 30, 2020

It seems device-width meta tag is missing

<meta name="viewport" content="width=device-width, initial-scale=1.0">

Is there a way to set this with esdocs? If not perhaps use Javascript to do that

@soryy708
Copy link
Contributor Author

@soryy708 soryy708 commented May 31, 2020

@sushantdhiman I made the requested changes

@sushantdhiman sushantdhiman merged commit 1b86729 into sequelize:master Jun 1, 2020
4 checks passed
@sushantdhiman
Copy link
Contributor

@sushantdhiman sushantdhiman commented Jun 1, 2020

Thanks @soryy708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants